]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
Revert "signalTracker: Use WeakMap in SignalManager to avoid leaking objects"
authorSebastian Keller <skeller@gnome.org>
Fri, 2 Sep 2022 16:37:13 +0000 (18:37 +0200)
committerMarge Bot <marge-bot@gnome.org>
Sat, 3 Sep 2022 15:11:46 +0000 (15:11 +0000)
This reverts commit 085102be74f4c98094712a165e5128feaca50438.

We need the SignalManager map top be iterable at shutdown for some of
the following changes. A WeakMap is not iterable. This revert changes it
back to a regular Map, which re-introduces the leaks caused by this.
Those will be fixed differently by the two followup commits.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2466>

js/misc/signalTracker.js

index 8444564df4d1727de4fc17a571f2f41b85f3d22c..1c3f4f9df4d17b53ceed4d7aa56886be0a0da7ca 100644 (file)
@@ -42,7 +42,7 @@ class SignalManager {
     }
 
     constructor() {
-        this._signalTrackers = new WeakMap();
+        this._signalTrackers = new Map();
     }
 
     /**